Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Disconnected Spans exported for Remote-log-url #1280

Merged
merged 14 commits into from
Dec 13, 2024
Merged

Fix: Disconnected Spans exported for Remote-log-url #1280

merged 14 commits into from
Dec 13, 2024

Conversation

coolwednesday
Copy link
Contributor

@coolwednesday coolwednesday commented Dec 9, 2024 •
edited
Loading

Pull Request Template

Description:

  • Closes Disconnected Spans are exported to the remote-log-url #1278
  • Previously disconnected spans were created for each fetch request of the remote log .....
  • The change in code makes sure that the all the traces exported for one http-request has spans in hierarchy.
  • It also makes sure that we don't export retry connection logs for sql connection, as it is not a developer concern. Logs will be suffice in such case.
Screenshot 2024-12-09 at 1 46 45 PM

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

Umang01-hash
Umang01-hash requested changes Dec 10, 2024
View reviewed changes
pkg/gofr/exporter.go Outdated Show resolved Hide resolved
pkg/gofr/service/new.go Outdated Show resolved Hide resolved
Umang01-hash
Umang01-hash previously approved these changes Dec 10, 2024
View reviewed changes
@aryanmehrotra aryanmehrotra merged commit 2ebf567 into gofr-dev:development Dec 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Umang01-hash Umang01-hash Umang01-hash approved these changes

@aryanmehrotra aryanmehrotra aryanmehrotra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disconnected Spans are exported to the remote-log-url
3 participants
@coolwednesday @aryanmehrotra @Umang01-hash