Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : Server shouldn't start if HTTP_PORT is blocked #1319

Open
wants to merge 20 commits into
base: development
Choose a base branch
from
Open

Fix : Server shouldn't start if HTTP_PORT is blocked #1319

wants to merge 20 commits into from

Conversation

coolwednesday
Copy link
Contributor

@coolwednesday coolwednesday commented Dec 19, 2024 •
edited
Loading

Description:

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

Umang01-hash
Umang01-hash reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@Umang01-hash Umang01-hash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add some test covering the new statements of code?

pkg/gofr/gofr.go Show resolved Hide resolved
pkg/gofr/gofr.go Outdated Show resolved Hide resolved
ccoVeille
ccoVeille reviewed Dec 19, 2024
View reviewed changes
pkg/gofr/grpc.go Outdated Show resolved Hide resolved
pkg/gofr/gofr.go Outdated Show resolved Hide resolved
ccoVeille
ccoVeille suggested changes Dec 19, 2024
View reviewed changes
pkg/gofr/gofr.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Umang01-hash Umang01-hash Umang01-hash left review comments

@ccoVeille ccoVeille ccoVeille requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server shouldn't start if HTTP_PORT is blocked
3 participants
@coolwednesday @ccoVeille @Umang01-hash