Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove gofr's dependency from ftp package #1320

Open
wants to merge 8 commits into
base: development
Choose a base branch
from
Open

remove gofr's dependency from ftp package #1320

wants to merge 8 commits into from

Conversation

Umang01-hash
Copy link
Contributor

Pull Request Template

Description:

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

@Umang01-hash Umang01-hash changed the title remofe gofr's dependency from ftp package remove gofr's dependency from ftp package Dec 19, 2024
ccoVeille
ccoVeille reviewed Dec 19, 2024
View reviewed changes
pkg/gofr/datasource/file/ftp/interface.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/file/ftp/interface.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/file/ftp/file.go Show resolved Hide resolved
@Umang01-hash
Copy link
Contributor Author

The failing S3 tests and build for the workflow run can be addressed by this PR: #1324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove datasources' dependency on GoFr
2 participants
@Umang01-hash @ccoVeille