-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move mock_logger from testutil to logger #582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shifting the mockLogger to a sub package does not really change anything. Log level for examples are not the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can see separately if we even want to use MockLogger, as NewLogger should also be good to use!
mocklogger
was present as part of testutil package which isn't ideal.NOTE:
NewRemoteLogger
is renamed toNew
, since now it is part ofremotelogger
package.Checklist:
goimport
andgolangci-lint
.