Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for internal server to do error log #625

Merged
merged 3 commits into from
May 17, 2024

Conversation

vipul-rawat
Copy link
Member

Pull Request Template

Description:

Error log for 5xx responses from server.

Additional Information:
Fixes issue #614
image

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

@srijan-27 srijan-27 linked an issue May 16, 2024 that may be closed by this pull request
Copy link
Member

@aryanmehrotra aryanmehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per issue ticket Additionally, for JSON logging, the log should contain the error message

In JSON format error message is not coming.

@Umang01-hash Umang01-hash merged commit c9840db into development May 17, 2024
13 checks passed
@Umang01-hash Umang01-hash deleted the fix-middleware-log branch May 17, 2024 10:41
@srijan-27 srijan-27 mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Internal server error logs are not coming under Error level log
5 participants