Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/auto increment add rest handlers #930

Merged
merged 11 commits into from
Aug 21, 2024

Conversation

Umang01-hash
Copy link
Contributor

@Umang01-hash Umang01-hash commented Aug 14, 2024

Pull Request Template

Description:

Example:

type user struct {
	Id         int    `json:"id"  sql:"auto_increment"`
	Name       string `json:"name"  sql:"not_null"`
	Age        int    `json:"age"`
	IsEmployed bool   `json:"isEmployed"`
}

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

@Umang01-hash Umang01-hash marked this pull request as ready for review August 14, 2024 06:27
pkg/gofr/crud_handlers.go Outdated Show resolved Hide resolved
pkg/gofr/crud_handlers.go Outdated Show resolved Hide resolved
pkg/gofr/crud_handlers.go Show resolved Hide resolved
pkg/gofr/crud_handlers.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/sql/query_builder.go Outdated Show resolved Hide resolved
@Umang01-hash Umang01-hash requested a review from ccoVeille August 16, 2024 07:06
@ccoVeille
Copy link
Contributor

There is something I don't get.

You said you changed things and you asked for review, but I see nothing new.

Did I miss something or you forgot pushing?

@Umang01-hash
Copy link
Contributor Author

There is something I don't get.

You said you changed things and you asked for review, but I see nothing new.

Did I miss something or you forgot pushing?

I forgot to push @ccoVeille. Did it now

@srijan-27 srijan-27 mentioned this pull request Aug 19, 2024
@aryanmehrotra aryanmehrotra merged commit b98a7a3 into development Aug 21, 2024
12 checks passed
@aryanmehrotra aryanmehrotra deleted the fix/auto_increment_add_rest_handlers branch August 21, 2024 12:33
@reski-rukmantiyo
Copy link
Contributor

Thanks @Umang01-hash and Team to cover my pull. Thank you very much

@Umang01-hash
Copy link
Contributor Author

@reski-rukmantiyo Thankyou for your contributions also. Keep using GoFr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants