Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

En/fix multipart form types #986

Merged
merged 25 commits into from
Sep 17, 2024
Merged

En/fix multipart form types #986

merged 25 commits into from
Sep 17, 2024

Conversation

Umang01-hash
Copy link
Contributor

@Umang01-hash Umang01-hash commented Sep 4, 2024 •
edited
Loading

Pull Request Template

Description:

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

@Umang01-hash Umang01-hash marked this pull request as ready for review September 4, 2024 09:33
ccoVeille
ccoVeille reviewed Sep 4, 2024
View reviewed changes
pkg/gofr/http/multipart_file_bind.go Outdated Show resolved Hide resolved
pkg/gofr/http/multipart_file_bind.go Outdated Show resolved Hide resolved
pkg/gofr/http/multipart_file_bind.go Outdated Show resolved Hide resolved
pkg/gofr/http/multipart_file_bind.go Outdated Show resolved Hide resolved
pkg/gofr/http/multipart_file_bind.go Outdated Show resolved Hide resolved
pkg/gofr/http/multipart_file_bind_test.go Outdated Show resolved Hide resolved
pkg/gofr/http/multipart_file_bind_test.go Outdated Show resolved Hide resolved
pkg/gofr/http/multipart_file_bind_test.go Outdated Show resolved Hide resolved
pkg/gofr/http/multipart_file_bind.go Outdated Show resolved Hide resolved
pkg/gofr/http/multipart_file_bind.go Outdated Show resolved Hide resolved
ccoVeille
ccoVeille approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for applying the changes I suggested

ccoVeille
ccoVeille reviewed Sep 4, 2024
View reviewed changes
pkg/gofr/http/multipart_file_bind_test.go Outdated Show resolved Hide resolved
pkg/gofr/http/multipart_file_bind_test.go Outdated Show resolved Hide resolved
pkg/gofr/http/multipart_file_bind_test.go Outdated Show resolved Hide resolved
aryanmehrotra
aryanmehrotra requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@aryanmehrotra aryanmehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add docs as well!

vipul-rawat
vipul-rawat previously approved these changes Sep 17, 2024
View reviewed changes
aryanmehrotra
aryanmehrotra previously approved these changes Sep 17, 2024
View reviewed changes
@aryanmehrotra aryanmehrotra merged commit d8dd55a into development Sep 17, 2024
12 checks passed
@aryanmehrotra aryanmehrotra deleted the en/fix_multipart_form_types branch September 17, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryanmehrotra aryanmehrotra aryanmehrotra approved these changes

@ccoVeille ccoVeille ccoVeille approved these changes

@vipul-rawat vipul-rawat vipul-rawat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Umang01-hash @ccoVeille @aryanmehrotra @vipul-rawat