Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc sys app automatic deployment #524

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Fix doc sys app automatic deployment #524

merged 6 commits into from
Nov 30, 2023

Conversation

James-Mart
Copy link
Member

@James-Mart James-Mart commented Nov 30, 2023 •
edited
Loading

Docs are now available at doc-sys.roothost after boot. Served through psispace

@James-Mart James-Mart added the Dev Experience Related to the experience of developers label Nov 30, 2023
@James-Mart James-Mart added the documentation Improvements or additions to documentation label Nov 30, 2023
swatanabe
swatanabe reviewed Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@swatanabe swatanabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the benefit of creating a separate service.

services/user/DocSys/src/DocSys.cpp Outdated Show resolved Hide resolved
doc/psidk/book.toml.in Outdated Show resolved Hide resolved
.vscode/settings.json.sample Show resolved Hide resolved
@James-Mart
Copy link
Member Author

I don't understand the benefit of creating a separate service.

Not much, right now. But it makes it more consistent with the other apps and fixed its availability post boot.
The doc-sys app can now be stateful, which could be helpful for the future. For example it could also serve as a standard location for app docs, similar to crates.io.

@James-Mart
Copy link
Member Author

Reverted the conversion to a stateful app.

@James-Mart James-Mart merged commit 6f24e4e into main Nov 30, 2023
3 checks passed
@James-Mart James-Mart deleted the fix-doc-sys-app branch November 30, 2023 22:11
@James-Mart James-Mart changed the title Fix doc sys app Fix doc sys app automatic deployment Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatanabe swatanabe swatanabe approved these changes

Assignees
No one assigned
Labels
Dev Experience Related to the experience of developers documentation Improvements or additions to documentation
Projects
Psibase
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@James-Mart @swatanabe