Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo-psibase #534

Merged
merged 49 commits into from
Mar 4, 2024
Merged

Update cargo-psibase #534

merged 49 commits into from
Mar 4, 2024

Conversation

James-Mart
Copy link
Member

@James-Mart James-Mart commented Dec 11, 2023

This reverts commit 2550f84 which unified all rust module version numbers under the workspace. This is much nicer for version management, however it precludes being able to publish updated versions to crates.io. See this github issue for more details.

This PR also rewrites the linker used by cargo-psibase that polyfills wasi imports. The old linker:

  1. Used parity-wasm, which is now deprecated
  2. Didn't work for services built with bulk-memory support

The new linker uses walrus.

rust/psibase/Cargo.toml Show resolved Hide resolved
rust/publish.sh Outdated Show resolved Hide resolved
rust/cargo-psibase/src/link.rs Outdated Show resolved Hide resolved
rust/cargo-psibase/src/link.rs Outdated Show resolved Hide resolved
rust/cargo-psibase/src/link.rs Outdated Show resolved Hide resolved
rust/cargo-psibase/src/link.rs Outdated Show resolved Hide resolved
rust/cargo-psibase/src/link.rs Outdated Show resolved Hide resolved
@James-Mart James-Mart marked this pull request as ready for review February 29, 2024 21:14
rust/scripts/set-version.sh Outdated Show resolved Hide resolved
rust/cargo-psibase/src/link.rs Outdated Show resolved Hide resolved
rust/cargo-psibase/src/link.rs Outdated Show resolved Hide resolved
rust/cargo-psibase/src/link.rs Outdated Show resolved Hide resolved
rust/cargo-psibase/src/link.rs Outdated Show resolved Hide resolved
rust/cargo-psibase/test-data/intermediate.wasm Outdated Show resolved Hide resolved
@James-Mart
Copy link
Member Author

CI/CD failure is:

/usr/bin/ar: unable to copy file 'lib/libbinaryen.a'; reason: No space left on device
2024-03-03T18:40:01.7020452Z   gmake[2]: *** [CMakeFiles/binaryen.dir/build.make:438: lib/libbinaryen.a] Error 1

Happens since trying to add a cargo test step to ctest.

rust/Cargo.lock Outdated Show resolved Hide resolved
@swatanabe
Copy link
Collaborator

CI/CD failure is:

/usr/bin/ar: unable to copy file 'lib/libbinaryen.a'; reason: No space left on device
2024-03-03T18:40:01.7020452Z   gmake[2]: *** [CMakeFiles/binaryen.dir/build.make:438: lib/libbinaryen.a] Error 1

binaryen is huge. It's using >4GiB in the build directory. It looks like it's only used in build.rs. Maybe replace that with wasm-opt as well?

@James-Mart
Copy link
Member Author

CI/CD failure is:

/usr/bin/ar: unable to copy file 'lib/libbinaryen.a'; reason: No space left on device
2024-03-03T18:40:01.7020452Z   gmake[2]: *** [CMakeFiles/binaryen.dir/build.make:438: lib/libbinaryen.a] Error 1

binaryen is huge. It's using >4GiB in the build directory. It looks like it's only used in build.rs. Maybe replace that with wasm-opt as well?

Oh yeah, I should do that anyway

@James-Mart
Copy link
Member Author

James-Mart commented Mar 4, 2024

Maybe replace that with wasm-opt as well?

Done

@James-Mart James-Mart merged commit 50162a6 into main Mar 4, 2024
3 checks passed
@James-Mart James-Mart deleted the cargo-psibase-fixes branch March 4, 2024 18:16
@James-Mart James-Mart added the Dev Experience Related to the experience of developers label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Experience Related to the experience of developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants