Add service pre-loading #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonfancher
force-pushed
the
dev/add-preload
branch
from
4ea08ba
to
f97e502
Compare
swatanabe
added
the
Plugin Infra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the ability to spin up for iframes of services we know we will use ahead of time, later on this could potentially be automatic if we track dependencies further.
This also adds a new method for the supervisor package
await supervisor.onLoaded();which ensures we do not attempt to send messages to the iframe before it's initialized. This wasn't needed before because of the time it takes a user to engage communication.Config change⚠️
I was getting type issues with
@messagingwhich went away with the removal ofinclude: src/uiin thetsconfig.jsoneverything else seems to be running okay.