Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional account name restrictions #672

Merged
merged 8 commits into from
Mar 28, 2024

Conversation

James-Mart
Copy link
Member

@James-Mart James-Mart commented Mar 28, 2024

Hyphens cannot be in the first or last positions of an account.

  • Cannot be in the first or last position because account names are intended to be subdomains, and that is part of the DNS rules.

Additionally, an account name may not start with x-. This prefix is reserved for use by the infra providers, intended so that there is a namespace at which subjective apps can be served from the node without fear of shadowing real user accounts/apps.

@James-Mart James-Mart added the Dev Experience Related to the experience of developers label Mar 28, 2024
@James-Mart James-Mart marked this pull request as draft March 28, 2024 13:15
@James-Mart James-Mart removed the request for review from swatanabe March 28, 2024 13:16
@James-Mart James-Mart marked this pull request as ready for review March 28, 2024 18:05
services/system/AccountSys/src/AccountSys.cpp Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
services/system/AccountSys/src/AccountSys.cpp Outdated Show resolved Hide resolved
@James-Mart James-Mart merged commit 6b6edc5 into main Mar 28, 2024
3 checks passed
@James-Mart James-Mart deleted the update-account-name-restrictions branch March 28, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Experience Related to the experience of developers
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants