Add example app #689
Merged
Add example app #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Mart
requested changes
Apr 17, 2024
| @@ -18,6 +21,15 @@ impl Intf for Component { | |||
| fn helloworld2() -> Result<String, CommonTypes::Error> { | |||
There was a problem hiding this comment.
you could also delete helloworld and helloworld2 if you want, just to clean up the example app
dev/demoapp1-build-and-deploy.sh
Outdated
There was a problem hiding this comment.
At some point this should also be deleted. We can just set up demoapp1 in cmake so it's not deployed separately. Should also help make sure we don't break demoapp1 when its dependencies change (if we change common plugin interfaces, and such, for example).
|
@James-Mart I've made those changes except the Rust wrapper import, I can't crack that... will try get on a call and sus it. |
James-Mart
reviewed
Apr 23, 2024
| @@ -3,11 +3,16 @@ package demoapp1:example; | |||
| interface intf { | |||
| use common:plugin/types.{error}; | |||
| helloworld2: func() -> result<string, error>; | |||
| multiply: func(a: u32, b: u32) -> result<string, error>; | |||
There was a problem hiding this comment.
Bit odd for multiply to return a string
James-Mart
approved these changes
Apr 23, 2024
|
Feel free to merge before you start getting merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.