Improve token service graphql queries #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Mart
commented
May 20, 2024
services/user/XAdmin/ui/yarn.lock
Outdated
James-Mart
added
the
System app
swatanabe
reviewed
May 20, 2024
swatanabe
reviewed
May 22, 2024
swatanabe
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new capability to graphql queries in C++: A vector of objects dynamically constructed at query time can be more easily queried using graphql.
The tokens query service uses this to allow for pagination on a dynamically constructed vector of objects, rather than returning the entire vector.
New queries:
userBalances(AccountNumber user, ...pagination)userCredits(AccountNumber user, ...pagination)userDebits(AccountNumber user, ...pagination)tokenDetails(TID tokenId)The first three queries manually construct an index that combines the normal balance table row with details about the token (symbolID and precision) in order to return all relevant details within a single query.
The fourth new query
tokenDetailsreturns details about a token given its ID, including the current owner of the issuer NFT, and the auth-service set by that owner account.