Add SplitKey type for subindexing in token query service #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatanabe
reviewed
May 24, 2024
Comment on lines
275
to
285
| /// A split key is used to specify a subindex on indices with a struct key. | ||
| /// | ||
| /// For example, a primr | ||
| /// Warning: No type checking! It's up to the user to ensure that T + Rest | ||
| /// is equivalent to the primary key) | ||
| template <typename Rest, typename T> | ||
| struct SplitKey | ||
| { | ||
| T value; | ||
| }; | ||
|
|
There was a problem hiding this comment.
The reason I suggested SplitKey is that it's non-intrusive. If we're adding this to the main Table.hpp header, a better solution would be to add an overload of subindex that takes an explicit type.
subindex<Rest>(key)
There was a problem hiding this comment.
I decided to make this non-intrusive rather than try to figure out how to implement your subindex idea
James-Mart
changed the title
SplitKey type for subindexingSplitKey type for subindexing in token query service
swatanabe
approved these changes
May 29, 2024
James-Mart
added
System app
James-Mart
changed the title
SplitKey type for subindexing in token query service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SplitKeytype to the token query service to allow subindexing on indices with a struct key