Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attestation UI #741

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Attestation UI #741

merged 4 commits into from
Jun 14, 2024

Conversation

cool-ant
Copy link
Member

This is the "initial" implementation of the Attestation UI for the (not yet extant) Attestation service

brandonfancher
brandonfancher approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@brandonfancher brandonfancher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Builds and runs in dev and preview well. I'm adding just a couple comments to address. And there is a good amount of commented code... but sounds like you're still working on cleanup. Approved.

services/user/Attestation/ui/package.json Outdated Show resolved Hide resolved
services/user/Attestation/ui/src/Sidebar.tsx Outdated Show resolved Hide resolved
@cool-ant cool-ant merged commit 99f0a0d into main Jun 14, 2024
4 checks passed
@cool-ant cool-ant deleted the mm/initial-Attestation branch June 14, 2024 20:22
@James-Mart James-Mart added the System app Related to system services and their apps/plugins label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonfancher brandonfancher brandonfancher approved these changes

Assignees
No one assigned
Labels
System app Related to system services and their apps/plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cool-ant @brandonfancher @James-Mart @GreenBusDriver