Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Reflect #788

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Remove Reflect #788

merged 6 commits into from
Jul 26, 2024

Conversation

swatanabe
Copy link
Collaborator

  • Add actions to schema so that the schema can fill all the roles previously handled by Reflect

#[derive(
Debug, Copy, Clone, Pack, Unpack, Reflect, Serialize, Deserialize, SimpleObject, InputObject,
)]
#[derive(Debug, Copy, Clone, Pack, Unpack, Serialize, Deserialize, SimpleObject, InputObject)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was ToSchema intended here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wouldn't hurt to add ToSchema, but it isn't actually needed yet, since NewAccountRecord isn't used in any action or event signatures.

@swatanabe swatanabe merged commit 9fdb348 into main Jul 26, 2024
4 checks passed
@swatanabe swatanabe deleted the no-reflect branch July 26, 2024 17:40
@James-Mart James-Mart added the Dev Experience Related to the experience of developers label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Experience Related to the experience of developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants