Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fracpack for Python #801

Merged
merged 34 commits into from
Aug 14, 2024
Merged

Fracpack for Python #801

merged 34 commits into from
Aug 14, 2024

Conversation

swatanabe
Copy link
Collaborator

  • Move ServiceSchema into the main psibase lib and add serveSchema which defines the /schema endpoint (matching rust)
  • Use /schema instead of /pack_action to pack actions in the tests.
  • Rewrite C++ Schema minimization to fix some edge cases that accidentally skipped some types.
  • Standardize MethodNumber hashing to use seahash. Update the crate version, because 2.4 is buggy. Remove cityhash.
  • Generate a json file with test cases for fracpack

@swatanabe
Add python port of fracpack
c413992
@swatanabe
Replace HTTP /pack/ calls with fracpack module
4697490
@swatanabe
Simplify definitions
e2e2306
@swatanabe
Fix build with -fno-exceptions
69e083a
@swatanabe
Convert schema types to be derived from type, and allow creating obje…
fb10f7a 
…cts from them, (mainly for Object and Struct)
@swatanabe
Merge remote-tracking branch 'origin/main' into fracpack-port
de4a345
@swatanabe
Add a test for empty nested fracpack
5dc970a
@swatanabe
Add /schema endpoint to C++ services and use it instead of /pack_acti…
776c7e7 
…on in tests
@swatanabe
Add a few more tests for option/container edge cases
e738ad4
@swatanabe
Ensure that custom checks for matching types
232855e
@swatanabe
Implement unpack
8231707
@swatanabe
Add invalid test cases to json
95fc92c
@swatanabe
Add tests for compatibility
5dd5b35
@swatanabe
Rename private types
07a608a
@swatanabe
Adjust docs for __init__
668e23a
@swatanabe
Handle empty members at the end
c74266e
@swatanabe
Merge remote-tracking branch 'origin/main' into fracpack-port
06bbedf
@swatanabe
Fix use of unpack
3038b33
@swatanabe
Fix tests
83077ff
@swatanabe
Update seahash. 2.4 is buggy
23f9323
@swatanabe
Implement name uncompress
53d1b08
@swatanabe
Add a few more tests for method names and fix the python impl
5d2f97c
@swatanabe
Make C++ method number match rust
b632e5e
@swatanabe
Make hash_name equivalent to method_to_number. There's no good reason…
a970af4 
… for them to be different and we're not keeping the uses distinct. Remove consthash (cityhash) dependency.
@swatanabe
Update Cargo.locks
29f7d57
@swatanabe
Add python tests to ctest
24939aa
@swatanabe
Fix Custom
db7e3d1 
- With nothing overridden, lookup a replacement or use nested "type"
- Derived for Option should override embedded pack/unpack
- Derived for non-Option should override plain pack/unpack
@swatanabe
Merge remote-tracking branch 'origin/main' into fracpack-port
9049e8b
@swatanabe
Pass empty claims to Transaction
eb47cc8
@swatanabe
Wrong variable
6cd75e6
@James-Mart James-Mart added the Dev Experience Related to the experience of developers label Aug 14, 2024
@swatanabe swatanabe merged commit 9049afd into main Aug 14, 2024
4 checks passed
@swatanabe swatanabe deleted the fracpack-port branch August 14, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@James-Mart James-Mart James-Mart approved these changes

Assignees
No one assigned
Labels
Dev Experience Related to the experience of developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swatanabe @James-Mart