Propagate graphql errors as errors instead of success response #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Mart
reviewed
Aug 8, 2024
James-Mart
reviewed
Aug 8, 2024
cool-ant
force-pushed
the
mm/supervisor-graphql-error-propagation
branch
from
7546071
to
0cbc847
Compare
James-Mart
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supervisor was returning graphql errors as successes, which caused unrelated downstream issues because everything downstream was expecting good results but getting body = "errors": { ...error stuff... }
Now graphql errors are thrown in the JS context