Optimize unit tests #848
Merged
Optimize unit tests #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
swatanabe
commented
Sep 12, 2024
•
swatanabe
commented
| before | after | |
|---|---|---|
| t-Nft-test | 33.11 sec | 1.65 sec |
| t-Symbol-test | 34.89 sec | 2.08 sec |
| t-Tokens-test | 90.30 sec | 2.53 sec |
| t-psibase-tests | 9.84 sec | 1.63 sec |
- Use a single shared wasm cache, to reduce compiling (huge impact) - Save ExecutionMemory's when closing a chain and re-use them for future chains. (small but noticable impact) - When DefaultTestChain is constructed, clone a template chain using new host function cloneChain, to avoid needing to boot a new chain for every test case. (huge impact)
James-Mart
approved these changes
Sep 23, 2024
| * @param flags must include at least either O_RDONLY or O_RDWR, and | ||
| * can also contain O_CREAT, O_EXCL, and O_TRUNC. | ||
| */ | ||
| TestChain(std::string_view path, |
There was a problem hiding this comment.
The meaning of the pub param should probably be added as doc comments above the relevant constructors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.