Union cargo package dependencies #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Mart
requested review from
swatanabe
and removed request for
swatanabe
swatanabe
approved these changes
Sep 30, 2024
| @@ -205,7 +205,7 @@ pub async fn build_package( | |||
| metadata: &MetadataIndex<'_>, | |||
| service: Option<&str>, | |||
| ) -> Result<PackageInfo, anyhow::Error> { | |||
| let mut depends = vec![]; | |||
| let mut depends_set = HashSet::new(); | |||
There was a problem hiding this comment.
The elements are already being sorted. Adding a dedup at that point is probably more efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows package dependencies to be specified in any crate in a cargo-package instead of only the service crate.
Dependencies put in multiple crates will be unioned for inclusion in the final package.
This PR also moves the dependencies for the ChainMail package from the service crate to the root crate. It does not demonstrate unioning capabilities which were manually tested.
Merge to
mainonce #859 is merged.