Make sleep interruptible when request context expire. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this library in a CLI tool, I like to connect a context to CTRL-C signal allowing for early interruption. The problem is that with very long second rate limit, you can get the CLI lock in a sleep that can not be interrupted which is not ideal. This PR address that problem by using the context from the request and a timer channel to handle this scenario.
This comes with test for verifying that SleepWithContext behave as expected. I have introduced the use of testify by habit mostly, but the test look nicer with it in my opinion. Let me know if you prefer a different approach for the test.