-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go.mod with v3 #44
Conversation
For #43 |
3 similar comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I believe that we should add go 1.11 with modules support to travis. Not sure if that should go here. To do this, we would need to set GO111MODULE=on env variable. We have go tip in travis, so it would run on that. |
I think 1.11 support for travis should go in a different PR. I filed #45 to that effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Does A secondary question, assuming it does need to be there is there a way we can think of to amortize the cost and have it be done automatically? How about flagging bad releases? |
@theckman thanks for your question, i'm not so sure, will look more. |
In the wiki:
|
For the second question, it's maybe related to golang/go#27009 (that confirm in the same time that we need the /v3 in go.mod) ? |
We may just need to merge this, and deal with the cancer. |
No pressure, it'll still be usable without |
I think this can be merged as-is now, unfortunate as the situation may be. This PR is about v3, but I thought I'd mention that we don't have a |
Add go.mod with v3 Signed-off-by: Tim Heckman <t@heckman.io>
No description provided.