Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go.mod with v3 #44

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Add go.mod with v3 #44

merged 1 commit into from
Aug 30, 2018

Conversation

flibustenet
Copy link
Contributor

No description provided.

@flibustenet
Copy link
Contributor Author

For #43

@coveralls
Copy link

Pull Request Test Coverage Report for Build 137

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.143%

Totals Coverage Status
Change from base Build 135: 0.0%
Covered Lines: 347
Relevant Lines: 350

💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 137

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.143%

Totals Coverage Status
Change from base Build 135: 0.0%
Covered Lines: 347
Relevant Lines: 350

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 137

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.143%

Totals Coverage Status
Change from base Build 135: 0.0%
Covered Lines: 347
Relevant Lines: 350

💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 23, 2018

Pull Request Test Coverage Report for Build 137

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.143%

Totals Coverage Status
Change from base Build 135: 0.0%
Covered Lines: 347
Relevant Lines: 350

💛 - Coveralls

Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niaow
Copy link
Member

niaow commented Aug 23, 2018

I believe that we should add go 1.11 with modules support to travis. Not sure if that should go here. To do this, we would need to set GO111MODULE=on env variable. We have go tip in travis, so it would run on that.

@acln0
Copy link
Member

acln0 commented Aug 23, 2018

I think 1.11 support for travis should go in a different PR. I filed #45 to that effect.

Copy link
Member

@niaow niaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theckman
Copy link
Member

theckman commented Aug 24, 2018

Does v3 need to be in the file? Why can't the SCM tagging be used to provide the major version? It's provided as metadata on the repo, will be part of the natural release process, and subsequently won't be stale.

A secondary question, assuming it does need to be there is there a way we can think of to amortize the cost and have it be done automatically? How about flagging bad releases?

@flibustenet
Copy link
Contributor Author

@theckman thanks for your question, i'm not so sure, will look more.

@flibustenet
Copy link
Contributor Author

In the wiki:
https://github.com/golang/go/wiki/Modules#semantic-import-versioning

If the module is version v2 or higher, the major version of the module must be included in both the module path in the go.mod file (e.g., module example.com/my/mod/v2) and the package import path (e.g., import "example.com/my/mod/v2/foo").

@flibustenet
Copy link
Contributor Author

For the second question, it's maybe related to golang/go#27009 (that confirm in the same time that we need the /v3 in go.mod) ?

@theckman
Copy link
Member

We may just need to merge this, and deal with the cancer.

@flibustenet
Copy link
Contributor Author

flibustenet commented Aug 26, 2018

No pressure, it'll still be usable without go.mod. Feel free to wait if you think it's too early.

@acln0
Copy link
Member

acln0 commented Aug 30, 2018

I think this can be merged as-is now, unfortunate as the situation may be.

This PR is about v3, but I thought I'd mention that we don't have a go.mod for v2, and I don't know how easy it would be to backport one, or if we even care to do so. In the meantime, module users who want v2 can go get github.com/gofrs/uuid@v2.1.0 and they'll get a require github.com/gofrs/uuid v2.1.0+incompatible in their go.mod. Oh well.

@theckman theckman merged commit 5258b0c into gofrs:master Aug 30, 2018
theckman added a commit that referenced this pull request Aug 30, 2018
Add go.mod with v3

Signed-off-by: Tim Heckman <t@heckman.io>
@niaow niaow mentioned this pull request Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants