Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: fix improper PAM authorization handling #6819

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Conversation

ysf
Copy link
Contributor

@ysf ysf commented Mar 8, 2022

Describe the pull request

Disallow expired accounts or accounts with expired passwords to login.

Link to the issue: #6810

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

@unknwon unknwon changed the title fix: pam authorization security: fix improper PAM authorization handling Mar 8, 2022
@unknwon unknwon linked an issue Mar 8, 2022 that may be closed by this pull request
1 task
internal/auth/pam/pam.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #6819 (d732d74) into main (242deca) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #6819   +/-   ##
=====================================
  Coverage   8.93%   8.93%           
=====================================
  Files         98      98           
  Lines      13231   13231           
=====================================
  Hits        1182    1182           
  Misses     11885   11885           
  Partials     164     164           

@unknwon unknwon merged commit 940a7da into gogs:main Mar 8, 2022
@unknwon unknwon mentioned this pull request Mar 11, 2022
29 tasks
unknwon pushed a commit that referenced this pull request Mar 11, 2022
Co-authored-by: Joe Chen <jc@unknwon.io>
# Conflicts:
#	CHANGELOG.md
#	internal/auth/pam/pam.go
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper PAM authorization handling
2 participants