Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] ] support accessory in either order #19906

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Jan 24, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

fixes goharbor#19795, remove the noise in the log

Signed-off-by: wang yan <wangyan@vmware.com>
In certain cases, the OCI client may push the subject artifact and accessory in either order.
Therefore, it is necessary to handle situations where the client pushes the accessory ahead of the subject artifact.

Signed-off-by: wang yan <wangyan@vmware.com>
Needs to set the repo when to handle the accessory before subject manifest.

Signed-off-by: wang yan <wangyan@vmware.com>
Fix the keywords when to list accessories belong to the subject manifest.

Signed-off-by: wang yan <wangyan@vmware.com>
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (8d0c8d4) 0.00% compared to head (170e1e5) 67.42%.
Report is 9 commits behind head on release-2.9.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.9.0   #19906       +/-   ##
==================================================
+ Coverage               0   67.42%   +67.42%     
==================================================
  Files                  0      993      +993     
  Lines                  0   108982   +108982     
  Branches               0     2752     +2752     
==================================================
+ Hits                   0    73476    +73476     
- Misses                 0    31544    +31544     
- Partials               0     3962     +3962     
Flag Coverage Δ
unittests 67.42% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/lib/config/userconfig.go 68.42% <ø> (ø)
src/pkg/accessory/manager.go 83.69% <100.00%> (ø)
src/pkg/accessory/dao/dao.go 61.44% <33.33%> (ø)
src/server/middleware/subject/subject.go 48.48% <46.15%> (ø)

... and 989 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 5d27ccf into goharbor:release-2.9.0 Jan 25, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants