Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Test Case for SBOM feature #20797

Merged
merged 1 commit into from
Aug 1, 2024
Merged

add Test Case for SBOM feature #20797

merged 1 commit into from
Aug 1, 2024

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Jul 31, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #20580

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.23%. Comparing base (c8c11b4) to head (56d850e).
Report is 247 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20797       +/-   ##
===========================================
+ Coverage   45.36%   66.23%   +20.86%     
===========================================
  Files         244     1045      +801     
  Lines       13333   113501   +100168     
  Branches     2719     2845      +126     
===========================================
+ Hits         6049    75174    +69125     
- Misses       6983    34216    +27233     
- Partials      301     4111     +3810     
Flag Coverage Δ
unittests 66.23% <ø> (+20.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1287 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 295e075 into goharbor:main Aug 1, 2024
22 checks passed
kunal-511 pushed a commit to kunal-511/harbor_local that referenced this pull request Aug 22, 2024
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
reasonerjt pushed a commit to reasonerjt/harbor that referenced this pull request Aug 29, 2024
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
stonezdj pushed a commit that referenced this pull request Aug 30, 2024
add Test Case for SBOM feature (#20797)

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
Co-authored-by: Shengwen YU <yshengwen@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add test for SBOM
7 participants