Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golang version #21014

Merged
merged 17 commits into from
Oct 10, 2024
Merged

update golang version #21014

merged 17 commits into from
Oct 10, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Oct 9, 2024

to golang v1.23.2

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

to golang v1.23.2

Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 requested a review from a team as a code owner October 9, 2024 04:22
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 47.40741% with 142 lines in your changes missing coverage. Please review.

Project coverage is 66.17%. Comparing base (c8c11b4) to head (d950c9e).
Report is 287 commits behind head on main.

Files with missing lines Patch % Lines
src/controller/scan/base_controller.go 12.50% 7 Missing ⚠️
src/server/v2.0/handler/robot.go 0.00% 7 Missing ⚠️
src/server/v2.0/handler/user.go 14.28% 6 Missing ⚠️
src/server/middleware/blob/head_blob.go 0.00% 5 Missing ⚠️
src/server/v2.0/handler/artifact.go 28.57% 5 Missing ⚠️
src/server/v2.0/handler/project.go 0.00% 5 Missing ⚠️
src/server/v2.0/handler/retention.go 0.00% 5 Missing ⚠️
src/controller/scanner/base_controller.go 0.00% 4 Missing ⚠️
src/controller/usergroup/controller.go 0.00% 4 Missing ⚠️
src/server/v2.0/handler/gc.go 0.00% 4 Missing ⚠️
... and 64 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #21014       +/-   ##
===========================================
+ Coverage   45.36%   66.17%   +20.80%     
===========================================
  Files         244     1048      +804     
  Lines       13333   114469   +101136     
  Branches     2719     2856      +137     
===========================================
+ Hits         6049    75752    +69703     
- Misses       6983    34574    +27591     
- Partials      301     4143     +3842     
Flag Coverage Δ
unittests 66.17% <47.40%> (+20.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/common/rbac/project/evaluator.go 67.92% <100.00%> (ø)
src/common/rbac/system/evaluator.go 100.00% <100.00%> (ø)
src/controller/artifact/controller.go 62.30% <100.00%> (ø)
src/controller/artifact/processor/chart/chart.go 61.76% <100.00%> (ø)
src/controller/artifact/processor/default.go 54.76% <100.00%> (ø)
...controller/artifact/processor/image/manifest_v1.go 69.56% <100.00%> (ø)
...controller/artifact/processor/image/manifest_v2.go 71.21% <100.00%> (ø)
src/controller/artifact/processor/wasm/wasm.go 66.21% <100.00%> (ø)
src/controller/blob/controller.go 71.36% <100.00%> (ø)
src/controller/config/controller.go 30.40% <100.00%> (ø)
... and 116 more

... and 1161 files with indirect coverage changes

Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 added the release-note/update Update or Fix label Oct 9, 2024
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -28,7 +28,7 @@ jobs:
- name: Set up Go 1.21
uses: actions/setup-go@v5
with:
go-version: 1.22.3
go-version: 1.23.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name should be "Set up Go 1.23"

@wy65701436 wy65701436 merged commit de28122 into goharbor:main Oct 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants