tpl/partials: Fix the lock contention in cached partial

Fixes #4086
gohugoio · Nov 16, 2017 · 6233ddf · 6233ddf
1 parent e66d813
commit 6233ddf
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/tpl/partials/partials.go b/tpl/partials/partials.go
@@ -120,19 +120,17 @@ func (ns *Namespace) getOrCreate(key, name string, context interface{}) (interfa
 		return p, nil
 	}
 
-	ns.cachedPartials.Lock()
-	defer ns.cachedPartials.Unlock()
-
-	// Double-check.
-	if p, ok = ns.cachedPartials.p[key]; ok {
-		return p, nil
-	}
-
 	p, err := ns.Include(name, context)
 	if err != nil {
 		return nil, err
 	}
 
+	ns.cachedPartials.Lock()
+	defer ns.cachedPartials.Unlock()
+	// Double-check.
+	if p2, ok := ns.cachedPartials.p[key]; ok {
+		return p2, nil
+	}
 	ns.cachedPartials.p[key] = p
 
 	return p, nil