Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always rebuild the files involved in an error #9884

Closed
bep opened this issue May 12, 2022 · 1 comment
Closed

Always rebuild the files involved in an error #9884

bep opened this issue May 12, 2022 · 1 comment
Assignees
Milestone

Comments

@bep
Copy link
Member

bep commented May 12, 2022

I was testing out some error handling issue an noticed that we, since we're a little conservative about when we rebuild CSS files (PostCSS takes time), and also that the current dependency mechanism have some holes in it (I have a much improved take on this in another branch), it means that when in server mode:

  • If you introduce an error in a CSS file, you get the error in the console and in the browser.
  • If you fix that error right away, everything is good.
  • But you wander on and edit something else that's not connected to the CSS (e.g. a template), the error goes away and does not come back until you edit something CSS related again.

The fix for this would be to always make sure that the files involved in a server error is always in the "change list" until they've been resolved.

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant