-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commands: Use consistent style when describing subcommands #12931
Conversation
docs/content/en/commands/hugo.md
Outdated
@@ -70,17 +70,17 @@ hugo [flags] | |||
|
|||
### SEE ALSO | |||
|
|||
* [hugo build](/commands/hugo_build/) - build builds your site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CLI docs is generated with go run main.go gen doc --dir docs/content/en/commands
, something we typically do before we release.
As to this PR, it would be much easier to review it without all the docs changes. So could you revert the docs
folder to master
and force push the PR branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
This looks very good, but there are some failing test assertions. |
Updated. |
There are two remaining subcommands to address: version and build. Current (with this PR):
As suggested in #12897:
|
Updated! |
Now we have this:
The |
@jmooring made the requested changes. |
This still isn't correct. See my previous comment regarding "version" vs. "env". |
You have at least one failing test. Run |
Fixed. |
This looks good. Please squash the commits, change the commit message to "Closes #12897", and force push. |
All squashed! |
This is a nit, but please change this:
To what I asked for in my previous comment:
See https://github.com/gohugoio/hugo/blob/master/CONTRIBUTING.md#git-commit-message-guidelines. |
Done, will keep this in mind for future contributions. Thank you very much for the tool. |
Current commit message:
What I asked for:
|
Closes gohugoio#12897 Change-Id: Ib27a4a7b540d45243e6252db769d4b9fb7447718 Signed-off-by: Rohan Hasabe <rohanhasabe8@gmail.com>
Adapting to language suggested in - (#12897)
Change-Id: Ib27a4a7b540d45243e6252db769d4b9fb7447718