Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Adjust test workflow to install Dart Sass v1.80.3 #12968

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

jmooring
Copy link
Member

No description provided.

@bep
Copy link
Member

bep commented Oct 19, 2024

Thanks for this. There is one upstream issue I want to understand before I merge this. Sass bumped to v3 of the protobuf protocol in 1.79.4 (which is why I picked 179.3 as the Docker version). Our use of Dart Sass seems to work fine with both old and new (not sure what changed), but I need to update the upstream libray (godartsass) before I can merge this.

bep/godartsass#29

@bep bep force-pushed the tests-bum-dar-sass-version branch from 1dbea2f to e900c9d Compare November 1, 2024 11:45
@bep bep merged commit 72352f2 into gohugoio:master Nov 1, 2024
6 checks passed
@jmooring jmooring deleted the tests-bum-dar-sass-version branch November 1, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants