Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON array-based data file handling regression #4373

Merged
merged 2 commits into from
Feb 2, 2018
Merged

Fix JSON array-based data file handling regression #4373

merged 2 commits into from
Feb 2, 2018

Conversation

vassudanagunta
Copy link
Contributor

@vassudanagunta vassudanagunta commented Feb 2, 2018

Fixes #4361, a regression introduced in Hugo v0.35.

New test code (first commit)

The first commit includes new test code that was also submitted via #4372 against the v0.34 branch to demonstrate that the updates tests did in fact all pass for that release. They will fail in this PR, against v0.35 code, until the second commit with the fix is added.

The new tests:

regression fix (second commit)

A comprehensive fix is not trivial because Hugo uses three different three unmarshalers that behave differently for the same data structures. In the interests of fixing the regression ASAP, this PR will only address the regression.

*  Adds retro-coverage for #4361
*  Verifies open issues #4138, #3890, #4366, 4083
*  Removes test reliance on the very code it is testing (hugo/parser package).
   Expected results are now all built manually / are more precise.
   Tests can run against different versions (no linkage errs)
This bug was introduced in Hugo 0.35.

Fixes #4361
@vassudanagunta vassudanagunta changed the title WIP: Fix JSON array-based data file handling regression Fix JSON array-based data file handling regression Feb 2, 2018
@bep bep merged commit 4402c07 into gohugoio:master Feb 2, 2018
@vassudanagunta vassudanagunta deleted the fix-json-array-data branch February 2, 2018 16:16
@vassudanagunta vassudanagunta restored the fix-json-array-data branch May 13, 2018 06:09
@github-actions
Copy link

github-actions bot commented Feb 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression: Fail to unmarshal JSON arrays
2 participants