Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LOG_TYPE environmental variable #120

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Added LOG_TYPE environmental variable #120

merged 1 commit into from
Feb 6, 2019

Conversation

woop
Copy link
Member

@woop woop commented Feb 6, 2019

This disables JSON logging by default, but allows the user to enable it by setting LOG_TYPE=JSON

Fix #104

This disables JSON logging by default, but allows the user to enable it by setting LOG_TYPE=JSON
@zhilingc
Copy link
Collaborator

zhilingc commented Feb 6, 2019

/approve

Is there anywhere we can document this?

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pradithya
Copy link
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants