Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BigQuery query template to retrieve training data #182

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Fix BigQuery query template to retrieve training data #182

merged 3 commits into from
Apr 18, 2019

Conversation

davidheryanto
Copy link
Collaborator

@davidheryanto davidheryanto commented Apr 17, 2019

Previous BigQuery query template used by DatasetService to retrieve training data has some errors for e.g. it creates query like

# mygcpproject.mydataset.mycolumn is not a valid column name
SELECT mygcpproject.mydataset.mycolumn FROM mygcpproject.mydataset.mycolumn LIMIT 5

This is a fix to the templates.

Extra notes

How to reproduce this error using Feast Python SDK which will call the DatasetService:

Assuming you have ingested feature: myentity.myfeature with event timestamp between 2019-01-01 and 2019-01-02

# Import details are ommitted
# ...

feature_set = FeatureSet(entity="myentity", 
                         features=["myentity.myfeature"])
dataset_info = feast_client.create_dataset(feature_set, "2019-01-01", "2019-01-02")
dataset = fs.download_dataset_to_df(dataset_info, staging_location="gs://mybucket")

@zhilingc
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot removed the lgtm label Apr 18, 2019
@pradithya
Copy link
Collaborator

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradithya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhilingc
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit aeb12cd into feast-dev:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants