Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prow job for unit testing Python SDK #209

Merged
merged 4 commits into from
May 31, 2019
Merged

Add Prow job for unit testing Python SDK #209

merged 4 commits into from
May 31, 2019

Conversation

davidheryanto
Copy link
Collaborator

No description provided.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidheryanto
Copy link
Collaborator Author

davidheryanto commented May 30, 2019

/hold
Waiting for #207 to be merged because it will fix the integration-test

Due to newer openjdk official image has different abosolute path to java exec
No longer at /usr/bin/java

Current integration test fail due to Feast core and serving image cannot start because of invalid java path

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented May 30, 2019

@davidheryanto: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
unit-test-cli 4ee4997 link /test unit-test-cli

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@davidheryanto
Copy link
Collaborator Author

/hold cancel

@budi
Copy link
Contributor

budi commented May 31, 2019

/lgtm

@budi
Copy link
Contributor

budi commented May 31, 2019

cli test is failing because golang map ordering is sometimes jumbled up (in the test we assumed it's ordered)

@budi budi merged commit d500001 into master May 31, 2019
@feast-ci-bot
Copy link
Collaborator

@davidheryanto: Updated the config configmap in namespace default using the following files:

  • key config.yaml using file .prow/config.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidheryanto davidheryanto deleted the unit-test branch July 16, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants