Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3 dev serving api change #253

Merged
merged 6 commits into from
Oct 3, 2019

Conversation

zhilingc
Copy link
Collaborator

@zhilingc zhilingc commented Oct 3, 2019

Changes to serving API:

  • Remove entityDataset, change to list of maps instead
  • Response is also a list of maps

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop merged commit 40bdd06 into feast-dev:0.3-dev Oct 3, 2019
@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Oct 3, 2019

@zhilingc: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
unit-test-cli fe3c16a link /test unit-test-cli
unit-test-python-sdk fe3c16a link /test unit-test-python-sdk
integration-test fe3c16a link /test integration-test
unit-test-core fe3c16a link /test unit-test-core
unit-test-ingestion fe3c16a link /test unit-test-ingestion

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants