Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redis transaction #280

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Conversation

pradithya
Copy link
Collaborator

Motivation:

We are setting up sharded with twemproxy in front of it. However, twemproxy doesn't support transaction (https://github.com/twitter/twemproxy/blob/master/notes/redis.md)

Modification:

  • Remove transaction in RedisCustomIO

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradithya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pradithya
Copy link
Collaborator Author

/assign @davidheryanto

@feast-ci-bot
Copy link
Collaborator

@pradithya: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-core-and-ingestion 74bff10 link /test test-core-and-ingestion
test-serving 74bff10 link /test test-serving
test-java-sdk 74bff10 link /test test-java-sdk
test-golang-sdk 74bff10 link /test test-golang-sdk
test-python-sdk 74bff10 link /test test-python-sdk
test-end-to-end 74bff10 link /test test-end-to-end

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhilingc
Copy link
Collaborator

/lgtm

@pradithya
Copy link
Collaborator Author

I'll merge manually since the test doesn't work

@pradithya pradithya merged commit 82569b0 into feast-dev:0.1.x Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants