Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow empty string to select a NoOp write transform #30

Merged
merged 2 commits into from
Jan 8, 2019

Conversation

tims
Copy link
Contributor

@tims tims commented Jan 3, 2019

This is for #5 .

Note this also allows core to return no warehouse store id and/or no serving store id in the feature specs. Either one, will be replaced with a NoOp.

@woop
Copy link
Member

woop commented Jan 3, 2019

Is it possible to rather have an option to turn off a store type instead of having empty strings?

@tims
Copy link
Contributor Author

tims commented Jan 3, 2019

Yes there is. If there is a storage spec that specifies type = "noop" you can use it's store id.

@woop
Copy link
Member

woop commented Jan 3, 2019

Yes there is. If there is a storage spec that specifies type = "noop" you can use it's store id.

I mean an option within the feature specification like useFeatureWarehouse: false

and then omitting the actual store from the spec.

@pradithya
Copy link
Collaborator

I mean an option within the feature specification like useFeatureWarehouse: false

Can we have this as separate issue?

@pradithya
Copy link
Collaborator

/retest

@woop
Copy link
Member

woop commented Jan 4, 2019

I mean an option within the feature specification like useFeatureWarehouse: false

Can we have this as separate issue?

Done #38

/retest

You need to rebase first @pradithya . You dont have a Makefile in the root of the repo with a test command in it.

@tims
Copy link
Contributor Author

tims commented Jan 6, 2019

rebased against master

/retest

@tims
Copy link
Contributor Author

tims commented Jan 6, 2019

/retest

@pradithya
Copy link
Collaborator

/lgtm

@tims
Copy link
Contributor Author

tims commented Jan 8, 2019

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 11114c5 into feast-dev:master Jan 8, 2019
@tims tims deleted the noop2 branch January 11, 2019 00:18
dmartinol pushed a commit to dmartinol/feast that referenced this pull request Jul 5, 2024
…istry

Store and Manage permissions in the Registry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants