Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set BigQuery table timepartition inside get table function #333

Merged
merged 4 commits into from
Nov 27, 2019
Merged

Set BigQuery table timepartition inside get table function #333

merged 4 commits into from
Nov 27, 2019

Conversation

zhilingc
Copy link
Collaborator

@zhilingc zhilingc commented Nov 27, 2019 •
edited
Loading

Fixes this error:

Caused by: java.lang.IllegalArgumentException: The supplied getTableFunction object can directly set TimePartitioning. There is no need to call BigQueryIO.Write.withTimePartitioning.
	at org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Preconditions.checkArgument(Preconditions.java:141)

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhilingc
Copy link
Collaborator Author

/retest

@zhilingc
Copy link
Collaborator Author

/retest

@zhilingc
Copy link
Collaborator Author

/retest

@davidheryanto
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 57b574e into feast-dev:master Nov 27, 2019
zhilingc pushed a commit to zhilingc/feast that referenced this pull request Nov 28, 2019
Set BigQuery table timepartition inside get table function (feast-dev…
ac6c18e 
…#333)

* Fix BigQuery write setting timepartition outside of table reference

* Give core a bit more time to start up

* Rename GetTableReference to correctly reflect return type

* Increase kafka sleep time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradithya pradithya Awaiting requested review from pradithya

@tims tims Awaiting requested review from tims

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@thirteen37 thirteen37 Awaiting requested review from thirteen37

@woop woop Awaiting requested review from woop

Assignees

@davidheryanto davidheryanto

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhilingc @feast-ci-bot @davidheryanto