Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize end-to-end test scripts #433

Merged
merged 1 commit into from
Jan 18, 2020

Conversation

Yanson
Copy link
Contributor

@Yanson Yanson commented Jan 17, 2020

What this PR does / why we need it:

Allow GCP project/bucket to be set in environment when running end-to-end tests. This is to allow us to run the e2e tests on our CI (Cloud Build) against our own GCP resources.

Additionally, 1/ allow skipping building of jars in e2e steps as we build them in a previous step, 2/ allow suffix to be specified to find jar as we use commit has rather than SNAPSHOT, 3/ print feast logs on test failure to help diagnosis.

This PR also aligns test-end-to-end.sh and test-end-to-end-batch.sh much more closely.

Which issue(s) this PR fixes:
This does not fix anything. The motivation was to be able replicate the test failures in #431 .

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

Hi @Yanson. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Yanson
Copy link
Contributor Author

Yanson commented Jan 17, 2020

/assign @woop

@khorshuheng
Copy link
Collaborator

/ok-to-test

@khorshuheng
Copy link
Collaborator

/lgtm

@khorshuheng
Copy link
Collaborator

/approve

@woop
Copy link
Member

woop commented Jan 18, 2020

Thanks for this @Yanson!

Will merge it in.

@khorshuheng
Copy link
Collaborator

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, woop, Yanson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit bb960a7 into feast-dev:master Jan 18, 2020
@Yanson Yanson deleted the parameterize_e2e branch January 20, 2020 09:47
khorshuheng pushed a commit to khorshuheng/feast that referenced this pull request Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants