Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md and remove versions from Helm Charts #457

Merged
merged 2 commits into from
Feb 3, 2020

Conversation

woop
Copy link
Member

@woop woop commented Feb 2, 2020

What this PR does / why we need it:

  • It updates the main README.md
  • Makes it required for users to provide an image.tag for Helm charts. Otherwise we will keep missing the update of versions in these charts and continue to deploy old docker images.

@khorshuheng
Copy link
Collaborator

/lgtm

@khorshuheng
Copy link
Collaborator

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit ff9bb75 into feast-dev:master Feb 3, 2020
khorshuheng pushed a commit to khorshuheng/feast that referenced this pull request Feb 14, 2020
* Update README.md and remove versions from Helm Charts

* Fix type in README.md
@khorshuheng khorshuheng mentioned this pull request Feb 14, 2020
khorshuheng pushed a commit that referenced this pull request Feb 14, 2020
* Update README.md and remove versions from Helm Charts

* Fix type in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants