Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose bug fix #661

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Conversation

woop
Copy link
Member

@woop woop commented Apr 29, 2020

What this PR does / why we need it:

  • Change docker compose file to use host based. This avoids having an inconsistency between default configuration and docker compose configuration.
  • Fix bug with application.yml typo
  • Fix port configuration bug for postgres

Which issue(s) this PR fixes:

Hopefully fixes all bugs in #652, but more changes are required to close the issue

Does this PR introduce a user-facing change?:

None

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khorshuheng
Copy link
Collaborator

There is one concern though - host network mode only works on Linux host machine. Mac users will not be able to use this.

@woop
Copy link
Member Author

woop commented Apr 29, 2020

There is one concern though - host network mode only works on Linux host machine. Mac users will not be able to use this.

Damnit I keep forgetting about that limitation. Isn't there a workaround that doesnt involve using private networks?

@khorshuheng
Copy link
Collaborator

The workaround i used personally, is to do port mapping on 9092 for Kafka. If i want to test using local jupyter notebook, i edit my etc hosts such that kafka:9092 points to localhost:9092 (so that it matches the advertised listener host). I do agree this is not a pretty workaround, though.

@woop woop force-pushed the fix-docker-compose branch from 5cb864b to 58dcc50 Compare April 29, 2020 04:26
@woop woop changed the title Docker compose bug fix and change to host networking Docker compose bug fix Apr 29, 2020
@woop
Copy link
Member Author

woop commented Apr 29, 2020

Removed host networking.

@woop woop added the lgtm label Apr 29, 2020
@feast-ci-bot feast-ci-bot merged commit d3ba7d8 into feast-dev:master Apr 29, 2020
@woop woop added the kind/bug label Apr 30, 2020
@woop woop mentioned this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants