Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag regex in tf file #73

Merged
merged 12 commits into from
Jan 16, 2019
Merged

Conversation

zhilingc
Copy link
Collaborator

Fixes #72

@zhilingc
Copy link
Collaborator Author

/assign woop

@woop
Copy link
Member

woop commented Jan 14, 2019

/lgtm

@woop
Copy link
Member

woop commented Jan 14, 2019

/lgtm cancel

@feast-ci-bot feast-ci-bot removed the lgtm label Jan 14, 2019
@tims
Copy link
Contributor

tims commented Jan 15, 2019

/hold

I find this base64encoded regex disturbing, can you explain the requirement for it?

@zhilingc
Copy link
Collaborator Author

/hold

I find this base64encoded regex disturbing, can you explain the requirement for it?

see #72

@tims
Copy link
Contributor

tims commented Jan 15, 2019

it's just unreadable is all.. I was wondering why it's a regex at all and it's just because our build feels weird.

/hold cancel
/lgtm so we can get the build working, but I'm trying to figure out how we make the build more maven native.

@tims
Copy link
Contributor

tims commented Jan 15, 2019

/lgtm

@woop
Copy link
Member

woop commented Jan 15, 2019

Think we should just remove the variable and add the regex (in Base64) inline.

@feast-ci-bot feast-ci-bot removed the lgtm label Jan 16, 2019
@zhilingc
Copy link
Collaborator Author

Think we should just remove the variable and add the regex (in Base64) inline.

Resolved, please have a look

@woop
Copy link
Member

woop commented Jan 16, 2019

/lgtm

@pradithya
Copy link
Collaborator

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradithya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit d191c3d into feast-dev:master Jan 16, 2019
lokeshrangineni pushed a commit to lokeshrangineni/feast that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants