Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move read transforms into "source" package as FeatureSources #74

Merged
merged 3 commits into from
Jan 19, 2019

Conversation

tims
Copy link
Contributor

@tims tims commented Jan 14, 2019

First attempt #61

/donotmerge

/assign zhilingc

@tims
Copy link
Contributor Author

tims commented Jan 14, 2019

/hold

@tims
Copy link
Contributor Author

tims commented Jan 14, 2019

/assign pradithya

@tims
Copy link
Contributor Author

tims commented Jan 15, 2019

/hold cancel

I think this is ready to merge now. This introduces breaking changes, for the import spec for file based imports, the "type" changes like so:

type: file, options: { format: csv} ----> type: file.csv
type: file, options: { format: json} ----> type: file.json

@tims
Copy link
Contributor Author

tims commented Jan 18, 2019

@zhilingc @pradithya can you please review this?

@pradithya
Copy link
Collaborator

I think this is ready to merge now. This introduces breaking changes, for the import spec for file based imports, the "type" changes like so:

type: file, options: { format: csv} ----> type: file.csv
type: file, options: { format: json} ----> type: file.json

I think core will also need to change since it check for the import spec before submitting it, correct @zhilingc ?

@tims
Copy link
Contributor Author

tims commented Jan 18, 2019

updated core import spec validator class

@pradithya
Copy link
Collaborator

/lgtm

@zhilingc
Copy link
Collaborator

Seems good. You're missing the license in some of the files though.
/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit b5e19bd into feast-dev:master Jan 19, 2019
Yanson pushed a commit to Yanson/feast that referenced this pull request Jul 29, 2020
tmihalac pushed a commit to tmihalac/feast that referenced this pull request Aug 12, 2024
Removed with_subclasses option (it's the default and unique behavior)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants