Remove historical feature in serving store #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
/lgtm cancel |
Merged
pradithya
force-pushed
the
no_historical_feature
branch
from
dcf244f
to
fc28b19
Compare
pradithya
changed the title
pradithya
changed the title
pradithya
force-pushed
the
no_historical_feature
branch
from
ce63292
to
9306d02
Compare
|
/hold cancel |
|
/retest |
tims
suggested changes
Feb 14, 2019
serving/src/main/java/feast/serving/service/BigTableFeatureStorage.java
Outdated
Show resolved
Hide resolved
serving/src/main/java/feast/serving/service/RedisFeatureStorage.java
Outdated
Show resolved
Hide resolved
|
@tims I updated the PR to exclude server-side timestamp filtering. The timestamp filter is now done in client side. |
|
Last feedback, ts_range in the sdk should be DateTime objects not strings. |
|
/retest |
tims
approved these changes
Feb 25, 2019
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@zhilingc can you please review |
added 7 commits
February 25, 2019 17:32
pradithya
force-pushed
the
no_historical_feature
branch
from
a6d66cf
to
317fdd3
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove historical value of feature in serving store. This is incomplete solution and currently is blocked by the issue with late data overwriting newer data.
It contains breaking changes in serving and all the client will have to be updated
/hold