trash-restore mapping

[ranebrown]

I'm trying to use trash-cli for delete operations using the below mappings. The delete works but restore seems to be broken for some reason. It will show the prompt to select a file to restore but then hangs after entering a number. Any ideas what is causing this?

# move file to trash
cmd trash %trash $fx
map D trash

# restore a file from trash
map U $trash-restore

[gokcehan]

@ranebrown Are you using fish? If so, #499 might be related.

[ranebrown]

I'm using bash 5.1.4 and I do have set shell sh in my config. I tried using a different shell, no bashrc, different set shell option but got the same behavior. I'm using lf v20 but fairly sure I was seeing this on previous versions as well.

[gokcehan]

@ranebrown Are you on Mac? If so, #480 might be related.

[MahouShoujoMivutilde]

This works fine for me, requires fzf.

#!/usr/bin/env sh
# (Better) interactive restore for trash-cli.

file="$(trash-list | grep "$(pwd)" | fzf | awk '{$1=$2=""; print substr($0,3)}')"

[ -z "$file" ] && exit 1

# THE KEY PART; yes, i know how ugly it looks
yes 0 | trash-restore "$file"

demo

02.18.Sunday.14.Feb.2021.mp4

[ranebrown]

I am on a Mac. I tried a mapping to that script and it does successfully restore a file but it hangs before displaying the fzf window until I press a key.

[ranebrown]

Hanging seems related to FZF_DEFAULT_OPS. This seems to work:

map U ${{
FZF_DEFAULT_OPTS=""
file="$(trash-list | grep "$(pwd)" | fzf | awk '{$1=$2=""; print substr($0,3)}')"

[ -z "$file" ] && exit 1

# THE KEY PART; yes, i know how ugly it looks
yes 0 | trash-restore "$file"
}}

[thepenguinthatwants]

This works fine for me, requires fzf.

#!/usr/bin/env sh
# (Better) interactive restore for trash-cli.

file="$(trash-list | grep "$(pwd)" | fzf | awk '{$1=$2=""; print substr($0,3)}')"

[ -z "$file" ] && exit 1

# THE KEY PART; yes, i know how ugly it looks
yes 0 | trash-restore "$file"

demo
02.18.Sunday.14.Feb.2021.mp4

This works so well that I very amazed.
Very interesting different ways that these functions can be implemented.

[gokcehan]

There has been multiple changes related to this. Feel free to reopen if the issue persists in r23.

[mroavi]

Here is a version based on #579 (comment) that supports selecting multiple files to restore:

# lfrc
cmd fzf-restore ${{
    ids="$(echo -ne '\n'              | \
      trash-restore                   | \
      awk '$1 ~ /^[0-9]+/ {print $0}' | \
      fzf --multi                     | \
      awk '{print $1}'                | \
      sed -z 's/\n/,/g;s/,$/\n/')"
    echo $ids | trash-restore 
    clear
}}


map U fzf-restore