Use valid address in pthread_setspecific to silence warnings #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karianna
approved these changes
Sep 4, 2024
dagood
approved these changes
Sep 4, 2024
thread_setup_unix.c
Outdated
| @@ -9,6 +9,9 @@ static pthread_mutex_t *mutex_buf = NULL; | |||
|
|
|||
| static pthread_key_t destructor_key; | |||
|
|
|||
| /* Used in pthread_setspecific. See https://github.com/microsoft/go/issues/1305. */ | |||
| static char stub; | |||
There was a problem hiding this comment.
Does this need to exist at the global scope, or could static char stub; or char stub; be declared just before the call?
If there's no difference, I think putting the declaration inside thread_id would be a bit clearer. And IMO putting it on the stack (if possible) raises the fewest questions from a reader's perspective. 😄
There was a problem hiding this comment.
Looks putting the variable in the function scope also works, and it does look clearer. I'll keep the static keyword, though, I would rather not pass a pointer to a stack-allocated variable that can be used outside the function frame, just in case it is used somewhere 😅.
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
qmuntal
added a commit
that referenced
this pull request
Sep 5, 2024
* use valid address in pthread_setspecific to silence warnings * Update thread_setup_unix.c Co-authored-by: Davis Goodin <dagood@users.noreply.github.com> * use local variable instead of global --------- Co-authored-by: Davis Goodin <dagood@users.noreply.github.com> (cherry picked from commit 6f4d87d)
dagood
pushed a commit
that referenced
this pull request
Sep 5, 2024
…168) * use valid address in pthread_setspecific to silence warnings * Update thread_setup_unix.c Co-authored-by: Davis Goodin <dagood@users.noreply.github.com> * use local variable instead of global --------- Co-authored-by: Davis Goodin <dagood@users.noreply.github.com> (cherry picked from commit 6f4d87d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building with a newer glibc (probably since 2.34) causes the following warning:
The is caused by the
accessattribute annotation ofpthread_setspecific, which was recently added.GCC defines the none mode of access as:
The access mode none specifies that the pointer to which it applies is not used to access the referenced object at all. Unless the pointer is null the pointed-to object must exist and have at least the size as denoted by the size-index argument. The object need not be initialized. The mode is intended to be used as a means to help validate the expected object size, for example in functions that call __builtin_object_size. See Object Size Checking.
We are passing
(void*)1as a NULL pointer, which doesn't meet thenoneaccess requirements. This PR fixes that by using a static stub char pointer.Fixes microsoft/go#1305.