[ms-go1.23-support] Error out when encoding hash objects not implemented by the built-in providers #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
changed the title
qmuntal
force-pushed
the
ms-go1.23-hashmshl
branch
from
a197832
to
2281bf3
Compare
|
macOS runners are failing because just today there is a scheduled burnout. See #213. |
qmuntal
force-pushed
the
ms-go1.23-hashmshl
branch
from
2281bf3
to
cb1b28d
Compare
dagood
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial backport of #161 to the
ms-go1.23-supportbranch.We shouldn't read arbitrary memory and return it to the caller unless we know what we are decoding. This PR makes calls to
MarshalBinaryandUnmarshalBinaryon hash objects to return an error when not using the built-in providers instead of attempting to marshal and unmarshal arbitrary memory, which normally end up in a panic while decoding the object.Note that in #161 we went a little further and made the
NewSHAXfunctions return an object that doesn't implement the encoding interfaces when not using the built-in providers. That change is too big to be backported.