Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix(dependency): resolve clickhouse dependency breaking changes #305

Merged
merged 1 commit into from
Nov 21, 2019
Merged

hotfix(dependency): resolve clickhouse dependency breaking changes #305

merged 1 commit into from
Nov 21, 2019

Conversation

bxcodec
Copy link
Contributor

@bxcodec bxcodec commented Nov 21, 2019 •
edited
Loading

fix #302

What I've done:

  • Change the click house package
  • Run go mod tidy

@bxcodec bxcodec mentioned this pull request Nov 21, 2019
Closed
@bxcodec bxcodec changed the title fix(dependency): resolve clickhouse dependency breaking changes hotfix(dependency): resolve clickhouse dependency breaking changes Nov 21, 2019
@coveralls
Copy link

coveralls commented Nov 21, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 564

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.14%
Totals Coverage Status
Change from base Build 558: 0.0%
Covered Lines: 2332
Relevant Lines: 4560
💛 - Coveralls

@FelixSeptem
Copy link

hope to merge this PR ASAP @dhui

@dhui dhui merged commit 41b578a into golang-migrate:master Nov 21, 2019
@dhui dhui mentioned this pull request Nov 21, 2019
Closed
@stanleynguyen
Copy link

@dhui Is a patch with this fix gonna be release soon? We're waiting for it to fix our build

@bxcodec
Copy link
Contributor Author

bxcodec commented Dec 10, 2019

Notes:

If this PR is not released yet, use the master version when doing go get

go get -tags 'postgres' -u github.com/golang-migrate/migrate/v4/cmd/migrate@master

@bxcodec bxcodec deleted the fixClickHouse branch December 11, 2019 10:56
@dhui
Copy link
Member

dhui commented Dec 16, 2019

Released v4.7.1

@renovate renovate bot mentioned this pull request May 22, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed on go1.13
5 participants
@bxcodec @coveralls @FelixSeptem @stanleynguyen @dhui