Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: Regenerate protos #142

Closed
wants to merge 2 commits into from
Closed

internal: Regenerate protos #142

wants to merge 2 commits into from

Conversation

sbuss
Copy link
Contributor

@sbuss sbuss commented May 24, 2018

Related to #140, this regenerates all of the .pb.go files. Used libprotoc 3.5.1

@sbuss sbuss requested review from broady and mtraver May 24, 2018 16:42
@sbuss
Copy link
Contributor Author

sbuss commented May 24, 2018

The tests are still failing due to #136 and #140, but this should minimize the diff in the required fixes (hopefully #141)

@sbuss sbuss mentioned this pull request May 24, 2018
Closed
@sbuss
Copy link
Contributor Author

sbuss commented Jun 1, 2018

I'm closing this until golang/protobuf#622 is resolved in either direction.

@sbuss sbuss closed this Jun 1, 2018
@sbuss sbuss deleted the regen-protos branch June 1, 2018 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broady broady Awaiting requested review from broady

@mtraver mtraver Awaiting requested review from mtraver

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sbuss