-
Notifications
You must be signed in to change notification settings - Fork 1k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this is okay, for now. I worry that we're baking in some assumptions that gps makes, like the input hash for lock files, but let's see where it takes us.
P: make([]gps.LockedProject, len(rl.P)), | ||
} | ||
|
||
for k, ld := range rl.P { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd go with i
instead of k
, as it's an index not a key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mm yes, fair
We could drop that memo prop now (though we'd still need the
Are there other assumptions there that concern you? |
(merged, given the approval, but i'm happy to still discuss) |
Yeah, that all makes sense.
Not that I can articulate right now. Let's see where this leads us. |
status: process detail template output all-at-once
Patterned quite strongly after #4